documentation: Info about offline s3 bucket key when creating feature group #2646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-cb
previously approved these changes
Sep 20, 2021
paul-cb
approved these changes
Sep 20, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
paul-cb
approved these changes
Sep 20, 2021
paul-cb
requested review from
jkroll-aws and
mchoi8739
and removed request for
mchoi8739
mchoi8739
suggested changes
Sep 21, 2021
| reduce AWS KMS requests costs by up to 99 percent. | ||
| For more information, see the S3 documentation for | ||
| `Bucket Key | ||
| <https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucket-key.html>`_. |
There was a problem hiding this comment.
AWS KMS key ID for offline store.
If a KMS encryption key is not specified, SageMaker encrypts all data at
rest using the default AWS KMS key. By defining your bucket-level key for SSE, you can
reduce the cost of AWS KMS requests.
For more information, see
Bucket Key <https://docs.aws.amazon.com/AmazonS3/latest/userguide/bucket-key.html>_
in the Amazon S3 User Guide.
There was a problem hiding this comment.
(You should not use any marketing words in the sdk docstrings.
There was a problem hiding this comment.
Revised according to your comments, thanks!
paul-cb
previously approved these changes
Sep 21, 2021
paul-cb
approved these changes
Sep 21, 2021
mchoi8739
approved these changes
Sep 21, 2021
shreyapandit
changed the title
shreyapandit
approved these changes
Sep 21, 2021
navinsoni
approved these changes
Sep 21, 2021
paul-cb
requested review from
mchoi8739
and removed request for
jkroll-aws and
mchoi8739
jkroll-aws
approved these changes
Sep 21, 2021
shreyapandit
changed the title
jerrypeng7773
pushed a commit
to jerrypeng7773/sagemaker-python-sdk
that referenced
this pull request
Sep 24, 2021
EthanShouhanCheng
pushed a commit
to SissiChenxy/sagemaker-python-sdk
that referenced
this pull request
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Documentation offline_store_kms_key_id is not inclusive and lead charging customers more on encryption.
Description of changes:
Add more descriptive documentation message of offline_store_kms_key_id in create feature group to elaborate how to bring down the cost of using bucket key.
Testing done:
tox
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.